Skip to content

release: publish checksums, find more builds and export only PyInit_monero #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
everoddandeven merged 3 commits into from
Nov 7, 2026
Merged

release: publish checksums, find more builds and export only PyInit_monero #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2541d06
release: look at more runs of main to find the builds of the tag
everoddandeven Nov 7, 2026
74d4fe9
release: publish the SHA256 sums of the assets
everoddandeven Nov 7, 2026
b0a751f
build: export only PyInit_monero from the module
everoddandeven Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
for wf in build-macos.yml build-windows.yml test.yml; do
key=$(echo "${wf%.*}" | tr '-' '_')
run_id=$(gh run list --repo "${{ github.repository }}" --workflow "$wf" \
--branch main --status success --json databaseId,headSha \
--branch main --status success --limit 200 --json databaseId,headSha \
--jq ".[] | select(.headSha == \"${{ github.sha }}\") | .databaseId" | head -n1)
if [ -z "$run_id" ]; then
echo "::error::No successful $wf run on main for commit ${{ github.sha }}. Push to main and wait for it to build before tagging."
Expand Down Expand Up @@ -113,6 +113,11 @@ jobs:
mkdir -p ../release-assets
zip -r ../release-assets/coverage_monero_cpp_html.zip coverage_monero_cpp_html

# to check a download against what the workflow published: sha256sum -c SHA256SUMS
- name: Checksum the assets
working-directory: release-assets
run: sha256sum -- *.deb *.whl *.zip > SHA256SUMS

- name: Create draft release
env:
GH_TOKEN: ${{ github.token }}
Expand All @@ -122,4 +127,4 @@ jobs:
--draft \
--title "${{ github.ref_name }}" \
--generate-notes \
release-assets/*.deb release-assets/*.whl release-assets/*.zip
release-assets/*.deb release-assets/*.whl release-assets/*.zip release-assets/SHA256SUMS
10 changes: 10 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,4 +351,14 @@ set(MONERO_PYTHON_LINK_LIBS

target_link_libraries(monero PRIVATE ${MONERO_PYTHON_LINK_LIBS})

# A python module has to export PyInit_monero and nothing else. Left to itself the linker also exports every
# symbol of the static libraries it takes in, those of monero-project and monero-cpp: about 27000 on linux, from
# 7000 to 11000 on macOS and 1100 on windows. They make the module bigger and can clash with the symbols that
# another extension of the same process brings, a boost or a protobuf for one.
if(APPLE)
target_link_options(monero PRIVATE -Wl,-dead_strip -Wl,-exported_symbol,_PyInit_monero)
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
target_link_options(monero PRIVATE -Wl,--exclude-libs,ALL -Wl,--gc-sections)
endif()

install(TARGETS monero DESTINATION .)
Loading