Repository navigation
accept RENAME_NOREPLACE in rename - #393
Open
abhinavagarwal07 wants to merge 1 commit into
Open
abhinavagarwal07 wants to merge 1 commit into
abhinavagarwal07 wants to merge 1 commit into
Conversation
macFUSE's FSKit backend sets it on every rename to a new name, so all such renames failed with EINVAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macFUSE's FSKit backend sets RENAME_NOREPLACE on every rename to a new name, so on macOS they all failed with EINVAL. Accept it and use plain SFTP rename, which the protocol defines as failing if the target exists.