Repository navigation
Conversation
ApplicationController imports jakarta.servlet.http, but the pom only provided the javax.servlet API (javaee-web-api 6.0), so compilation failed. The CI build step turned that failure into a warning, so the job stayed green. - Add jakarta.servlet:jakarta.servlet-api 6.0.0 with provided scope. - Upgrade maven-war-plugin 2.3 to 3.4.0. Version 2.3 cannot load on JDK 17 (TreeMap.comparator is not opened to the unnamed module), so the verify step failed during packaging. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Причина
ApplicationControllerимпортируетjakarta.servlet.http, но вpom.xmlбыл толькоjavax.servlet(javaee-web-api6.0). Компиляция на JDK 17 падает сpackage jakarta.servlet.http does not exist. Шагbuildвci.ymlпревращает эту ошибку в warning, поэтому job остаётся зелёным.verifyпадает при загрузкеmaven-war-plugin2.3: на JDK 17 плагин не работает (TreeMap.comparatorне открыт для unnamed module).Изменения (только
pom.xml)jakarta.servlet:jakarta.servlet-api:6.0.0со scopeprovided(в WAR не попадает).maven-war-plugin:2.3→3.4.0.Проверки (локально, JDK 17, те же команды, что в
ci.yml)mvn -B clean compile -Dmaven.test.skip=true -Djava.awt.headless=true→ BUILD SUCCESSmvn -B test -Djava.awt.headless=true→ BUILD SUCCESS (тестов в проекте нет)mvn -B verify -Dmaven.test.skip=true -Djava.awt.headless=true→ BUILD SUCCESS, WAR собранНе охвачено этим PR
8895006) остаётся без подтверждённой причины: логи job недоступны (HTTP 410). Этот PR не доказывает его исправления.ci.ymlпо-прежнему превращает ошибки сборки и тестов в warning. Изменение оставлено владельцу: рекомендуется сделать такие ошибки фатальными.check) фактически не проверяет код.🤖 Generated with Claude Code