Repository navigation
mtca: use nonzero timestamp - #9166
Merged
Merged
Conversation
This matches the format already used for the MirrorSignature lines.
CosignCheckpoint now takes a timestamp and returns a signature line. The places that called CosignCheckpoint followed by RawSignature and SignatureLine now just call CosignCheckpoint.
ezekiel
approved these changes
Nov 12, 2026
ezekiel
requested review from
a team and
aarongable
and removed request for
a team and
aarongable
November 12, 2026 18:17
beautifulentropy
approved these changes
Nov 12, 2026
aarongable
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CosignCheckpoint now takes a timestamp and returns a signature line. The places that called CosignCheckpoint followed by RawSignature and SignatureLine now just call CosignCheckpoint.
RawSignature is no longer needed so is deleted.
cosignature.SignatureLineis deleted, butcosignature.Cosigner.SignatureLineis still used by some tests so I haven't deleted it (yet).Note: Claude flags that
mtca_test.go:verifyCheckpoint()constructs a signed note with formatting directives rather than callingm.checkpointNote(). IMO that's fine: the format is simple enough that it's okay, desirable even, for the test to independently construct it.