Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #777.
A processing instruction such as
<?pi_target pi_content?>parses in the prolog, but fails inside an element or after the root/comment. Keep its existingXMLDeclarationrepresentation and exempt valid non-reserved PI targets from the declaration location checks. The existing name helpers identify the target; only XML whitespace can separate it from its data. All eight case variants of the reservedxmltarget retain the original checks.The older fork workaround linked in #777 removes the declaration location checks. This change retains those checks and their tests, with controls for malformed targets and unchanged opaque prolog handling.
Tested with Apple Clang 21 on macOS arm64:
xmltestreports 658 passing assertions, 0 failures; assertions after successful parses account for the different totals.