Repository navigation
Reject NUL and surrogate code points in GetCharacterRef - #1104
Open
darshan-mog wants to merge 1 commit into
Open
darshan-mog wants to merge 1 commit into
darshan-mog wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLUtil::GetCharacterRef only checks the decoded value against 0x10FFFF, so
�and the digit-less&#;/&#x;(which accumulate to 0) decode to a NUL byte that GetStr writes into the value, and<t v='admin�.evil.com'/>reads back asadminwith no error while conforming parsers reject the document. Surrogate references (�to�) are likewise encoded as invalid UTF-8 (ED A0 80). Reject these code points the same way out-of-range references already are, so the reference is left as literal text; a regression test is added next to the existing char ref tests.