Repository navigation
fix quadratic scan in XMLUtil::GetCharacterRef - #1102
Open
darshan-mog wants to merge 1 commit into
Open
darshan-mog wants to merge 1 commit into
darshan-mog wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLUtil::GetCharacterRef finds the end of a numeric character reference with strchr(';'), which scans the rest of the text or attribute value for every "&#", so unterminated references make GetText()/Attribute() quadratic: a 1 MB text node of "&#" repeated takes 11.8 s, 2.7 ms after this change. The same strchr also let a stray 'x' or '#' end the digit run, so "x41;" and "&#A" were silently resolved to "A"; scanning forward over radix digits only and rejecting on the first non-digit fixes both, with regression tests in xmltest.