Repository navigation
Upgrade KDS to 5.10.0 and use readonly choice controls in the choice interaction editor - #6317
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🟡 Waiting for changesLast updated: 2026-10-14 17:17 UTC |
Readonly radios still emit change when arrow keys move the native selection. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtibblesbot
left a comment
There was a problem hiding this comment.
PR #6317: no blocking issues. The disabled → readonly swap matches KDS 5.10.0. Clicks and keys leave answers unchanged. No sync changes are sent.
- Commits pushed after
90f953awere not reviewed. - CI pending.
- Manual QA passed: single- and multi-select view mode, edit → view round trips, and KDS 5.10.0 checkbox/radio/theme regressions elsewhere in Studio.
- Axe found nothing new on the choice controls.
- Not verified: server persistence of the multi-select edit (QA stack Redis failed).
- Not verified: real screen-reader output for
aria-readonly. - Suggestions and a nitpick inline.
Written by rtibblesbot, an LLM-based coding agent.
rtibblesbot
left a comment
There was a problem hiding this comment.
PR #6317: 1 of 3 prior findings resolved; 2 still open.
CI passing. Manual QA did not run, so the UI is unverified.
- suggestion (open thread on
Editor.vue:91): arrow keys still move focus across questions in view mode. No radio has aname. Chromium therefore treats every view-mode radio on the panel as one native group. Reply, fix, or file a follow-up. - nitpick (open thread on
Editor.spec.js:436): the new test at :453 throws instead of failing clearly when no answer is correct. Add the-1assertion suggested inline.
Prior-finding status
RESOLVED — contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/Editor.vue:182 — onToggleCorrect has no view-mode guard
UNADDRESSED — contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/Editor.vue:91 — Arrow keys move focus across questions in view mode
UNADDRESSED — contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/tests/Editor.spec.js:436 — Test throws instead of failing clearly without a correct answer
Written by rtibblesbot, an LLM-based coding agent.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtibblesbot
left a comment
There was a problem hiding this comment.
PR #6317: no new findings. 3 of 4 prior findings are resolved. The arrow-key focus finding is deferred to KDS#1334. CI passes. Manual QA found no regressions.
Prior-finding status
RESOLVED — contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/Editor.vue:182 — onToggleCorrect has no view-mode guard
ACKNOWLEDGED — contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/Editor.vue:91 — arrow keys move focus across questions in view mode (KDS#1334)
RESOLVED — contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/tests/Editor.spec.js — radio click test throws when fixture has no correct answer
RESOLVED — contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/tests/Editor.spec.js — native change test throws when fixture has no correct answer
Written by rtibblesbot, an LLM-based coding agent.
rtibbles
left a comment
There was a problem hiding this comment.
Code changes make sense, local QA checks out.
|
Quick check on rtibblesbot's review of this PR: react 👍 helpful · 😕 mixed · 👎 not helpful. Reply with anything specific. |
Summary
kolibri-design-systemfrom 5.9.0 to 5.10.0.readonlyinstead ofdisabled, using the new KDSreadonlyprop.References
readonlymode to KCheckbox, KRadioButton and KRadioButtonGroup kolibri-design-system#1342Reviewer guidance
aria-readonly, and the selection is unchanged after a click or a native radiochange. The full Jest suite passes locally.AI usage
I used Claude Code to bump KDS, replace
disabledwith the newreadonlyAPI in the choice interaction editor following the KDS 5.10.0 changelog, update the view-mode tests, and run the full Jest suite.🤖 Generated with Claude Code