Show QTI questions read-only when an edit would drop item-level content

[rtibblesbot]

Summary

• QTI questions open read-only when the root holds content the editor doesn't write, e.g. <qti-stylesheet>, <qti-modal-feedback>, a non-hint catalog, adaptive="true", or an outcome reference.
• Custom scoring stays editable; save regenerates it.
• Saves write xsi:schemaLocation, tool-name, tool-version, xml:lang for legacy language, and keep label.

References

Fixes #6290.

Reviewer guidance

• Allowlist of root attributes and children: validateItem.js; <qti-catalog-info> may hold only hint cards parseHints reads in full.
• Read-only items breaking an editor rule show Incomplete with the delete prompt.
• Open risk: an edit drops a non-zero SCORE default or custom partial credit.
• Known gap, QTI editor drops prefixed MathML from a question prompt on save #6308: MathML in a prompt saves as plain text.

Manual QA

QA team: questions now open read-only when an edit would lose content. Look for Studio-made questions that open read-only.

Import "Skeletal Structure - Practice" (Kolibri QA Channel, Courses > Hummingbird Biology > Anatomy & Physiology > Skeletal Structure) into an editable channel. Open Questions.

1. Edit: Edit an answer in question 1 two times. Mark another answer correct in question 2. Close and reopen each. The changes stay.
2. New questions: Add a choice and a Text entry question. Close and reopen each. Both stay as set.
3. German Numeric question: In Details, set Language to "Deutsch (de)". Add a Numeric question with the answers 0,5 and 1.234,5. Click Close, then Edit. The answers show as "0,5" and "1234,5". No read-only message or "Incomplete" shows.
4. Unreadable answer: Click Add acceptable answer, type 1,2,3, then move on. "Must be a valid number" shows.
5. Read-only messages: Look at the read-only questions under Evidence. Is each message clear? No QA Channel question opens read-only.

Evidence

Step	Screenshot
Before: printed-SCORE question editable
Root extras: read-only
German Numeric: 0,5, 1234,5, complete
German Numeric reopened editable
1,2,3 flagged
Read-only Numeric: answerless one Incomplete

Rule-breaking read-only questions deleted:

readonly-rules-delete-flagged.webm

Scoring extras stay editable:

s1x-edit-correct-answer-save-reopen.webm

More captures (27)

Step	Screenshot
Before: printed-SCORE question, Beta marked
Before: printed-SCORE question saved
Rule-breaking questions Incomplete
One deleted
Both deleted: complete
Scoring extras editable
Scoring extras: Bravo correct after reload
MAXSCORE question reopened
Root extras exercise details
adaptive="false", time-dependent="0": editable
false/0 question in the editor
Legacy language: Edit enabled
Legacy language in the editor
Legacy language reopened
Converted question, two hints
One hint left
Reopened: hint with image
Empty question list
New choice question
Choice question reopened
New text entry question
Text entry reopened
German Numeric in the side panel
Answerless question: Options, Delete

Legacy language, converted hints, new questions:

s3-legacy-language-edit-save-reopen.webm

s4-edit-delete-hint-save-reopen.webm

s5-text-entry-create-reopen.webm

Deviations from the issue spec

Criterion	Why not
Edits, including removing every hint, keep <qti-stylesheet>, <qti-modal-feedback>, non-hint catalogs	Read-only instead, as asked

AI usage

Claude Code wrote and self-reviewed it; Jest and pre-commit pass.

🤖 Generated with Claude Code

---

Written by rtibblesbot, an LLM-based coding agent.

🟡 Waiting for feedback Last updated: 2026-10-15 05:18 UTC

[rtibblesbot]

Reworked per @AlexVelezLl's direction: items with item-level content the editor doesn't write now open read-only instead of carrying it. The PR description above still describes the carry-over approach.

• Read-only: <qti-stylesheet>, <qti-modal-feedback>, outcomes other than SCORE/RAW_SCORE, catalogs or cards other than hints, response declarations no interaction uses, any other root child, unknown root attributes.
• Still editable, kept through an edit: xsi:schemaLocation (with xmlns:xsi), label, tool-name, tool-version. The converter writes these on every legacy question, so making them read-only would lock all converted items.
• keepsItemContent in assembleItem.js decides; QTIItemEditor and validateQtiItem both call it.

Deleting a hint on the xsi:schemaLocation item, then closing it. The stored raw_data keeps xsi:schemaLocation and has one hint left:

edit-schemalocation.webm

[AlexVelezLl]

The high level strategy proposed for this issue was too risky and prone to errors, where new introducedn editor capabilities could potentially drop support for questions created with older versions of it. Let's allow some flexibility in favor of a safer strategy for 99.99999% of cases.

[rtibblesbot]

Python unit tests red: test_restore_channel.py QTIRestoreTestCase, 7 failures — #6305. Same 7 fail on base afc8296ac locally; fix is in #6262. test_convert.py passes.

[rtibblesbot]

Python unit tests: the 7 QTIRestoreTestCase failures in test_restore_channel.py reproduce on base afc8296ac too (#6305, fixed by #6262). This branch's Python change, test_convert.py, passes (49 tests).

[AlexVelezLl]

Please rebase.

[rtibblesbot]

Rebased onto unstable (bdd38bb). Conflicts were only adjacent test additions in validateItem.spec.js and QTIItemEditor.spec.js; kept both sides. QTIEditor Jest suites pass (1714 tests).

[AlexVelezLl]

lgtm!

[rtibblesbot]

Quick check on rtibblesbot's work on this PR: react 👍 helpful · 😕 mixed · 👎 not helpful. Reply with anything specific.