Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm_output["model_name"]value as a fallbackRelated: langfuse/langfuse#4672
Verification
uv run --frozen pytest -n auto --dist worksteal tests/unit -q— 1039 passed, 2 skippeduv run --frozen ruff check .— passeduv run --frozen ruff format --check .— passeduv run --frozen mypy langfuse --no-error-summary— passedgit diff --check— passed

Confidence Score: 5/5
The PR appears safe to merge.Summary
The PR makes
_parse_modelprefer the returned model name over the request alias.No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "fix(langchain): prefer response model me..." · Reviewed by Greptile