Repository navigation
fix(utils): preserve staticmethod wrappers - #2141
Open
stussysenik wants to merge 1 commit into
Open
stussysenik wants to merge 1 commit into
stussysenik wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
auto_decorate_methods_with()replaced@staticmethoddescriptors with plainfunctions because
staticmethodis callable on Python 3.10+. Instance accessthen bound
selfinto a zero-selfmethod and the decorator swallowed theresulting
TypeError. Thecallableguard now excludesstaticmethodso theexisting staticmethod branch re-wraps
__func__and keeps the descriptor.No issue:
langfuse/langfuse-pythonrestricts issue creation tocollaborators (GraphQL
CreateIssuepermission error, REST POST 404). The bugand a runnable repro are reproduced in this PR body.
Type of change
Verification
Targeted: 3 passed. Ruff: pass. Mypy: exit 0. Full unit suite: 1012 passed /
26 errors, the same 26
test_prompt.pyerrors present on cleanmain.Checklist
code_review.md..env.templateif needed.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Preserves static methods when a class is decorated, so calling them through an instance no longer adds an unwanted argument.
No actionable issues found.
Reviews (1) · Last reviewed commit: "fix(utils): preserve staticmethod wrappe..." · Reviewed by Greptile