Skip to content

fix(sdk): make 401 and 405 API diagnostics actionable - #2140

Open
DevNeto07 wants to merge 1 commit into
langfuse:mainfrom
DevNeto07:Atualização/langfuse-actionable-api-error-messages

Hidden character warning

The head ref may contain hidden characters: "Atualiza\u00e7\u00e3o/langfuse-actionable-api-error-messages"
Open

DevNeto07 wants to merge 1 commit into
langfuse:mainfrom
DevNeto07:Atualização/langfuse-actionable-api-error-messages

Conversation

@DevNeto07

@DevNeto07 DevNeto07 commented Nov 18, 2026 •

Copy link
Copy Markdown

Summary

The Python SDK linked 401 errors to the TypeScript setup guide, and 405 errors fell back to a generic unexpected-error message. Point 401 diagnostics to the current credential setup guide and name the settings to verify. Give 405 errors a distinct message with base URL and server compatibility checks, and keep the support link.

Verification

  • Reproduced both old messages with the generated API exceptions. Updated the targeted assertions.
  • Error parsing and score consumer tests passed in Docker (44 tests). Ruff, formatting, mypy and git diff --check passed.
  • Claude Code reviewed the wording and suggested the SDK-specific 405 guidance.
  • Live-provider and end-to-end tests were skipped because the change only affects local logging for generated API errors.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

This PR makes 401 and 405 error messages more useful without changing how requests or exceptions work.

  • 401 errors name the SDK credentials users should check.
  • 405 errors suggest checking the base URL and server support.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(sdk): make 401 and 405 API diagnosti..." · Reviewed by Greptile

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@CLAassistant

CLAassistant commented Nov 18, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants