Skip to content

fix(serializer): resolve local timezone offsets at the event date - #2138

Open
DevNeto07 wants to merge 1 commit into
langfuse:mainfrom
DevNeto07:Atualização/langfuse-serialize-local-dst

Hidden character warning

The head ref may contain hidden characters: "Atualiza\u00e7\u00e3o/langfuse-serialize-local-dst"
Open

DevNeto07 wants to merge 1 commit into
langfuse:mainfrom
DevNeto07:Atualização/langfuse-serialize-local-dst

Conversation

@DevNeto07

@DevNeto07 DevNeto07 commented Nov 18, 2026 •

Copy link
Copy Markdown

Summary

Naive event datetimes were assigned the system's current UTC offset, which could shift the represented instant by one hour when the event date falls in a different daylight saving period. Use Python's local-time conversion for the specified date and preserve the existing rendering of aware values. For dates outside the platform conversion range, retain the existing current-offset fallback.

Verification

  • Reproduced the incorrect summer offset with a POSIX timezone and both winter and summer values.
  • Added checks for the repeated hour and extreme date values. The 53 serializer tests passed in Docker.
  • Ruff lint, Ruff formatting check for the touched files, mypy, and git diff --check passed.
  • End-to-end and live-provider checks were skipped because the behavior is local to serialization.
  • Claude Code reviewed the diff and identified the need to preserve support for dates outside the local-time conversion range.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Naive datetimes now use the local UTC offset for their event date, fixing errors across daylight saving periods.

  • Naive datetime strings use the offset for their own date.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(serializer): resolve local timezone ..." · Reviewed by Greptile

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@CLAassistant

CLAassistant commented Nov 18, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants