Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The prompt cache truncates wall-clock timestamps to whole seconds and uses a strict greater-than comparison. A cached prompt can stay fresh for up to one second beyond its TTL. Wall-clock changes can also shift its effective lifetime.
Use a monotonic deadline and refresh once the entry reaches its TTL. Stale-while-revalidate behavior remains the same. The regression test checks the same cached prompt just before and exactly at a fractional deadline.
Verification


Confidence Score: 5/5
This PR appears safe to merge.Summary
Prompt cache entries now expire exactly at their configured lifetime, without being affected by wall-clock changes.
No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "fix(prompts): expire cached prompts at t..." · Reviewed by Greptile