Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion langfuse/_utils/serializer.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from asyncio import Queue
from collections.abc import Sequence
from dataclasses import asdict, is_dataclass
from datetime import date, datetime
from datetime import date, datetime, time, timedelta
from json import JSONEncoder
from logging import getLogger
from pathlib import Path
Expand All @@ -15,6 +15,11 @@

from pydantic import BaseModel, SecretBytes, SecretStr

try:
from pydantic_core import to_jsonable_python
except ImportError:
to_jsonable_python = None

from langfuse.media import LangfuseMedia, LangfuseMediaReference

# Attempt to import Serializable
Expand All @@ -38,6 +43,38 @@ class Serializable: # type: ignore
_MIN_SAFE_INT = -(2**53) + 1


def _timedelta_to_iso8601(td: timedelta) -> str:
"""Format a datetime.timedelta as an ISO 8601 duration string (e.g. PT5M, PT1M30S)."""
total_seconds = td.total_seconds()
if total_seconds == 0:
return "PT0S"

sign = "-" if total_seconds < 0 else ""
total_seconds = abs(total_seconds)

days = int(total_seconds // 86400)
rem = total_seconds % 86400
hours = int(rem // 3600)
rem = rem % 3600
minutes = int(rem // 60)
seconds = rem % 60

sec_str = f"{seconds:.6f}".rstrip("0").rstrip(".") if seconds % 1 != 0 else str(int(seconds))

time_parts = []
if hours > 0:
time_parts.append(f"{hours}H")
if minutes > 0:
time_parts.append(f"{minutes}M")
if seconds > 0 or (days == 0 and hours == 0 and minutes == 0):
time_parts.append(f"{sec_str}S")

date_part = f"{days}D" if days > 0 else ""
t_part = f"T{''.join(time_parts)}" if time_parts else ""

return f"{sign}P{date_part}{t_part}"


class EventSerializer(JSONEncoder):
_MAX_DEPTH = 20

Expand Down Expand Up @@ -136,6 +173,14 @@ def _default_inner(self, obj: Any) -> Any:
if isinstance(obj, (date)):
return obj.isoformat()

if isinstance(obj, (time)):
return obj.isoformat()

if isinstance(obj, (timedelta)):
if to_jsonable_python is not None:
return to_jsonable_python(obj)
return _timedelta_to_iso8601(obj)

if isinstance(obj, Path):
return str(obj)

Expand Down
65 changes: 64 additions & 1 deletion tests/unit/test_serializer.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import json
import threading
from dataclasses import dataclass
from datetime import date, datetime, timezone
from datetime import date, datetime, time, timedelta, timezone
from enum import Enum
from pathlib import Path
from uuid import UUID
Expand Down Expand Up @@ -570,3 +570,66 @@ def test_dict_with_non_string_keys_is_serialized(input_obj, expected):
result = json.loads(EventSerializer().encode(input_obj))

assert result == expected


def test_time():
"""Resolves Issue #20158: datetime.time serializes to ISO format instead of '<time>'."""
t = time(9, 30, 0)
serializer = EventSerializer()
assert serializer.encode(t) == '"09:30:00"'


def test_time_with_microseconds_and_timezone():
"""datetime.time with fractional seconds and timezone info serializes accurately."""
t = time(9, 30, 15, 500000, tzinfo=timezone.utc)
serializer = EventSerializer()
assert serializer.encode(t) == '"09:30:15.500000+00:00"'


def test_timedelta():
"""Resolves Issue #20158: datetime.timedelta serializes to ISO 8601 duration instead of '<timedelta>'."""
td = timedelta(seconds=90)
serializer = EventSerializer()
assert serializer.encode(td) == '"PT1M30S"'


def test_timedelta_fractional_and_negative():
"""Fractional and negative timedeltas serialize to ISO 8601 duration cleanly."""
td_frac = timedelta(milliseconds=250)
serializer = EventSerializer()
assert serializer.encode(td_frac) == '"PT0.25S"'

td_neg = timedelta(seconds=-45)
assert serializer.encode(td_neg) == '"-PT45S"'


def test_pydantic_model_with_time_and_timedelta():
"""Pydantic models with time and timedelta fields serialize properly."""
class ModelWithTimeAndDuration(BaseModel):
scheduled_at: time
timeout: timedelta

model = ModelWithTimeAndDuration(
scheduled_at=time(14, 15),
timeout=timedelta(minutes=5)
)
serializer = EventSerializer()
res = json.loads(serializer.encode(model))
assert res == {
"scheduled_at": "14:15:00",
"timeout": "PT5M"
}


def test_dict_with_time_and_timedelta():
"""Dictionaries containing time and timedelta values preserve their real values."""
payload = {
"start": time(8, 0),
"duration": timedelta(hours=1, minutes=30)
}
serializer = EventSerializer()
res = json.loads(serializer.encode(payload))
assert res == {
"start": "08:00:00",
"duration": "PT1H30M"
}
Loading