Repository navigation
chore(ci): use npm stage publish - #34
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf59073242
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@claude review, esp if previous things were fixed |
There was a problem hiding this comment.
I re-reviewed the follow-up commit and found no new bugs. A human should still look before merging, because this changes how releases are published through OIDC and what the workflows will run on.
What was reviewed:
betaPublishPlannow requires a new beta to be greater thanlatest. Already-published retries still go through.assertNpmPublishContextchecks for npm >= 11.15.0, andcutReleaserunsnpmReleasePlanbefore changing package.json. The new end-to-end test covers all three cases.- release.yml now runs only on
refs/tags/v*, and theGITHUB_SHA/GITHUB_REFoverrides are replaced by a check that the ref and SHA match. Because of this, dispatching from main to rebuild an older tag is no longer supported. - The PR still relies only on the maintainer approving pending stages in version order (MAINTENANCE.md). Whether that is enough is a call for a human.
Extended reasoning...
The change touches both release workflows (release.yml now has a workflow_dispatch trigger guarded by a tag-ref check, and npm stage publish runs under OIDC id-token: write), plus the release and beta-release scripts and the maintainer docs. The security-sensitive surface is the publishing credentials and npm provenance binding, and which refs can reach the protected npm-publish environment. The newest commit adds an npm version preflight, a latest-floor check for betas, and an early channel-ordering check in cutRelease, and adds tests for them. Out-of-order approval of pending stages is still handled only by MAINTENANCE.md guidance, not by code. Release and CI policy changes of this kind should get a maintainer's sign-off, not an automated approval.
Still open from earlier reviews (1):
- Unresolved: 1 blocking on lines changed since (possibly already fixed).
If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.
This review covers commit af5be81, which is no longer the latest commit on this pull request; later commits are not covered by it.
No description provided.