Skip to content

chore(ci): use npm stage publish - #34

Merged
nimarb merged 3 commits into
mainfrom
nimar/switch-cli-npm-stage
Nov 3, 2026
Merged

nimarb merged 3 commits into
mainfrom
nimar/switch-cli-npm-stage

Conversation

@nimarb

@nimarb nimarb commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@nimarb
nimarb requested a review from a team as a code owner November 3, 2026 09:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T09:49:09.517313Z cf59073 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf59073242

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml Resolved

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread .github/workflows/release.yml Resolved
Comment thread scripts/beta-release.ts Resolved
Comment thread scripts/beta-release.ts Resolved
Comment thread scripts/release.ts Resolved
@nimarb

nimarb commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@claude review, esp if previous things were fixed

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-reviewed the follow-up commit and found no new bugs. A human should still look before merging, because this changes how releases are published through OIDC and what the workflows will run on.

What was reviewed:

  • betaPublishPlan now requires a new beta to be greater than latest. Already-published retries still go through.
  • assertNpmPublishContext checks for npm >= 11.15.0, and cutRelease runs npmReleasePlan before changing package.json. The new end-to-end test covers all three cases.
  • release.yml now runs only on refs/tags/v*, and the GITHUB_SHA/GITHUB_REF overrides are replaced by a check that the ref and SHA match. Because of this, dispatching from main to rebuild an older tag is no longer supported.
  • The PR still relies only on the maintainer approving pending stages in version order (MAINTENANCE.md). Whether that is enough is a call for a human.
Extended reasoning...

The change touches both release workflows (release.yml now has a workflow_dispatch trigger guarded by a tag-ref check, and npm stage publish runs under OIDC id-token: write), plus the release and beta-release scripts and the maintainer docs. The security-sensitive surface is the publishing credentials and npm provenance binding, and which refs can reach the protected npm-publish environment. The newest commit adds an npm version preflight, a latest-floor check for betas, and an early channel-ordering check in cutRelease, and adds tests for them. Out-of-order approval of pending stages is still handled only by MAINTENANCE.md guidance, not by code. Release and CI policy changes of this kind should get a maintainer's sign-off, not an automated approval.

Still open from earlier reviews (1):

  • Unresolved: 1 blocking on lines changed since (possibly already fixed).

If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.

This review covers commit af5be81, which is no longer the latest commit on this pull request; later commits are not covered by it.

@nimarb
nimarb enabled auto-merge (squash) November 3, 2026 10:34
@nimarb
nimarb merged commit 2842e31 into main Nov 3, 2026
3 checks passed
@nimarb
nimarb deleted the nimar/switch-cli-npm-stage branch November 3, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant