Repository navigation
fix(tracing): deduplicate mirrored base instructions - #131
Open
codingfeng-fufu wants to merge 1 commit into
Open
codingfeng-fufu wants to merge 1 commit into
codingfeng-fufu wants to merge 1 commit into
Conversation
Assisted-by: OpenAI Codex
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes langfuse/langfuse#20582.
Some Codex rollouts store the same base instructions in
session_metaand in a developer message. The plugin includes both copies when reconstructing the generation input and counts both incodex.system_prompt.total_chars.Skip a developer message when its text exactly matches the base instructions already read from the session header. Distinct developer messages still appear in their original order. The regression test runs the same rollout with and without the duplicate and checks both the exported generation input and the character metadata.
Validation on Node 24.22.3 in Windows:
e1d02beand passed with the change. Both focused cases pass.OpenAI Codex assisted with issue triage, implementation, and validation. The test uses synthetic rollout data.