Repository navigation
fix(utils): reject mi, ni and ui as quantity suffixes - #2748
Open
ArfiArfath21 wants to merge 1 commit into
Open
ArfiArfath21 wants to merge 1 commit into
ArfiArfath21 wants to merge 1 commit into
Conversation
kubernetes-prow
Bot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ArfiArfath21 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
kubernetes-prow
Bot
added
cncf-cla: no
ArfiArfath21
force-pushed
the
quantity-reject-invalid-binary-suffixes
branch
from
October 16, 2026 18:17
694d9a8 to
c831a6d
Compare
Author
|
/easycla |
parse_quantity and format_quantity only rejected 'ki' among the binary
suffixes, so 'mi', 'ni' and 'ui' were accepted as base-1024 negative
exponents (e.g. parse_quantity('1mi') == 1/1024). Binary suffixes are limited
to Ki, Mi, Gi, Ti, Pi and Ei.
ArfiArfath21
force-pushed
the
quantity-reject-invalid-binary-suffixes
branch
from
October 16, 2026 18:23
c831a6d to
b976cf7
Compare
Author
|
/easycla |
kubernetes-prow
Bot
added
cncf-cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
parse_quantityandformat_quantityonly rejectedkiamong the binary suffixes, somi,nianduiwere accepted as base-1024 negative exponents (parse_quantity("1mi")returned1/1024,format_quantity(Decimal(1), "mi")returned"1024mi"). Binary suffixes are now limited toKi,Mi,Gi,Ti,PiandEi, as in apimachinery'squantity.go. A typo such as512minow raisesValueErrorinstead of silently becoming a tiny number.Which issue(s) this PR fixes:
Fixes #2746
Special notes for your reviewer:
Tests added to
TestUtilsUnitTestsinkubernetes/e2e_test/test_utils.py; they fail onmasterand pass with this change.AI assistance disclosure: prepared with Claude Code; I reviewed the change and ran the tests locally.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: