Repository navigation
Relax the certifi lower bound and stop Dependabot raising lower bounds - #2745
sayaksatpathi wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sayaksatpathi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @sayaksatpathi! |
|
|
Dependabot raised certifi from >=14.05.14 to >=2026.7.22, which makes the client impossible to install next to an application that pins an older certifi. The client only calls certifi.where(), which every release provides. Lower the bound to 2024.7.4, the oldest release without a known advisory (CVE-2024-39689), and set versioning-strategy to widen for pip so Dependabot keeps the ranges of this library open instead of raising the lower bound on every new release.
c2b7c66 to
dc7a78a
Compare
|
/easycla |
|
/assign @lexdene |
|
@yliaog: GitHub didn't allow me to assign the following users: lexdene. Note that only kubernetes-client members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Dependabot raised
certififrom>=14.05.14to>=2026.7.22(#2660), so the client can't be installed next to an application that pins an older certifi. The client only callscertifi.where(), which every release provides.requirements.txt: lower the bound tocertifi>=2024.7.4. That is the oldest release with no known advisory (CVE-2024-39689 was fixed in 2024.7.4, checked against OSV), so it unblocks the reporter while keeping the bundles with the removed roots out..github/dependabot.yml: setversioning-strategy: widenfor pip, as discussed in the issue. By default Dependabot treatsrequirements.txtlike an application and raises the lower bound on every release. Withwiden, which is supported for pip, a>=range is left alone when the new release already satisfies it.Which issue(s) this PR fixes:
Fixes #2733
Special notes for your reviewer:
Other lower bounds in
requirements.txtwere raised the same way (pydantic, setuptools, typing-extensions, urllib3, durationpy). I left them alone to keep this focused, and can relax them in a follow-up if you want.Verification (certifi 2024.10.17 from the issue isn't on PyPI, so I used the nearest releases):
pip install --dry-run . certifi==2024.8.30andcertifi==2024.7.4fail with a resolution conflict on master and resolve with this change.certifi==2024.2.2is still rejected.kubernetes/config,stream,watch,utils,leaderelection,informerandkubernetes/testgive 290 passed. The 8 failures are Windows-only (7ws_clienttests patchselect.poll, and 1 timing assertion inincluster_config_test) and fail the same way with certifi 2026.7.22.I used Claude Code (AI) to help investigate and write this change, and reviewed and tested it before submitting.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
🤖 Generated with Claude Code