Repository navigation
[kubernetes] Fix Quantity.hashCode to honor equals/hashCode contract - #4953
Merged
kubernetes-prow[bot] merged 1 commit intoOct 23, 2026
Merged
Conversation
kubernetes-prow
Bot
added
do-not-merge/work-in-progress
kubernetes-prow
Bot
added
the
approved
Quantity.equals compares the underlying BigDecimal by value (ObjectUtils.compare -> BigDecimal.compareTo, scale-insensitive), but hashCode used Objects.hash(number) which is scale-sensitive. Value-equal quantities such as "1" and "1000m" (1.000) are therefore equal yet produce different hash codes, breaking HashMap/HashSet lookups. Normalize the scale with BigDecimal.stripTrailingZeros() before hashing so the hash is consistent with the value-based equals. Adds a focused unit test (fails before, passes after).
yue9944882
force-pushed
the
fix/core-npe
branch
from
October 22, 2026 17:27
f493213 to
441a5e5
Compare
brendandburns
marked this pull request as ready for review
October 23, 2026 13:54
kubernetes-prow
Bot
removed
the
do-not-merge/work-in-progress
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
merged commit Oct 23, 2026
cc7e0f4
into
kubernetes-client:master
21 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
io.kubernetes.client.custom.Quantityviolates theObject.equals/hashCodecontract.equals()compares the underlyingBigDecimalby value (ObjectUtils.compare→BigDecimal.compareTo, which is scale-insensitive).hashCode()usedObjects.hash(number), i.e.BigDecimal.hashCode(), which is scale-sensitive.So value-equal quantities with different scales are
equals()but have different hash codes. Example via the public API:This breaks
HashMap/HashSetmembership forQuantitykeys (a value inserted as1000mis not found when looked up as1).Fix
One line: normalize the scale with
BigDecimal.stripTrailingZeros()before hashing, making the hash consistent with the value-basedequals(). Null-guarded. Behavior-preserving otherwise.Verification
Added a focused unit test
QuantityTest.equalQuantitiesWithDifferentScaleHaveEqualHashCode.expected: <62> but was: <31034>.QuantityTest(2),QuantityFormatterTest(20),SuffixFormatterTest(16) all green.