Repository navigation
Start a new doc comment line at NEL, LINE SEPARATOR and PARAGRAPH SEPARATOR [patch] - #138
Merged
matt-edmondson merged 1 commit intoOct 14, 2026
Conversation
…ARATOR [patch] The compiler ends a /// comment at U+0085, U+2028 and U+2029 as well as at CR and LF. DocComment.SplitLines only split at CR and LF, so doc text holding one of the others pushed the rest of the line out of the comment and the generated file failed to compile. Fixes #129 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014h6btvAuM1Ew7cCFSpuFWc
|
matt-edmondson
deleted the
claude/issue-129-doc-comment-line-separators
branch
October 14, 2026 01:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129
What changed
DocComment.SplitLinesnow splits at U+0085, U+2028 and U+2029 as well as at CR, LF and CRLF. The compiler ends a///comment at any of these, so before this change, doc text containing one of them pushed the rest of the line out of the comment, and the generated file failed to compile (CS1570 and others).Tests
DocCommentTests.EveryLineTerminatorTheCompilerRecognisesStartsANewCommentLinehas one row per separator. Each row checks that the output matches the\nrendering and that every output line starts with///.🤖 Generated with Claude Code
https://claude.ai/code/session_014h6btvAuM1Ew7cCFSpuFWc
Generated by Claude Code