Repository navigation
Conversation
PR 9's reviewers planted bugs here that passed every test. Each new test fails against its planted bug and passes on main. - jumpToItem backward with no last jump, as the palette's "Previous" calls it: from between items, from an item's start, and from before every item. - removeAltVariant and removeVersionVariant with the removed variant before the active one: the active text stays on the page. - A swap is its own undo step: type next to an alternative, cycle it, and one undo takes back only the swap. The caret test that checks a word wins over its paragraph came with PR 9, so the older caret test is unchanged. No code changed: none of the tests found a bug.
gnapse
force-pushed
the
ernesto/quirky-aryabhata-1ace06
branch
from
October 29, 2026 03:41
367839b to
5dfc98c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9's two fresh reviewers planted bugs in the layer commands. Four passed every test. This PR adds a test for each. Only
src/editor/layers.test.tschanges: 4 tests, 40 lines. No bug found, so no code changed.New tests
jumpToItembackward with no last jump (⌥H in the palette passesnull). From between items, from an item's start, and from before every item.removeAltVariantandremoveVersionVariantwith the removed variant before the active one. The active text stays on the page, and the saved Markdown marks it.Each test fails against its planted bug
Checked on this branch's base, main 2e9a7e8. With no plant, 46/46 pass. Each plant fails exactly one test.
commands.tsfindLastIndex((i) => i.from < head)→findIndex((i) => i.from > head)[35, 1],[6, 0]<→<=[6, 0],[35, 2]removeVersionVariantkeepsactive'Three.','Two.'removeAltVariantkeepsalt.active'the strain here','the pressure here'annotations: ownStepremoved fromreplaceAltLeft as is
The old test "cycles the word at the caret before its paragraph" puts the word in a paragraph with no versions, so it can't check which one wins. PR #9's "cycles both ways at the caret" already does: making
cycleAtCarettry the paragraph first fails it ('First.', expected'Second one here.'). The old test is unchanged. Its name still claims more than it checks; a rename would fix that.Checks
pnpm verifypassed (types, tests, web build, Rust format, lint, tests). Nothing here touches the app window, AI calls, or files.