Repository navigation
Conversation
PKey.read only tried PKCS#8 on DER input (cherry picked from commit b07bf83) [backport: debugStackTrace instead of LOG.debugStack, which 0.16 doesn't have; test moved to src/test/ruby]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of b07bf83 to
0.16, which JRuby 10.0 and 9.4 bundle. On 0.16.3,OpenSSL::PKey.readcan't read the DER that#to_derwrites for RSA, DSA and EC private keys:Two changes from the original: the new catch block calls
debugStackTracelike its neighbours, since0.16has noLOG, and the test moved tosrc/test/ruby/test_pkey.rb.With JRuby 10.0 on JDK 21,
./mvnw testpasses as on0.16, andrake testruns 522 tests with no failures, one more than on0.16. The new test fails without the fix.