Skip to content

Check finished letters against the reference trace - #8

Merged
joshpitzalis merged 1 commit into
implement/strokesfrom
implement/7-whole-letter
Oct 24, 2026
Merged

joshpitzalis merged 1 commit into
implement/strokesfrom
implement/7-whole-letter

Conversation

@joshpitzalis

@joshpitzalis joshpitzalis commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

Check a complete letter attempt against its reference trace when the learner presses Check, regardless of stroke order, direction, pen lifts, or retracing.

draw → Check → reference coverage + stray-ink check
                 ├─ pass: retain the drawing and show success
                 └─ retry: retain editable ink and give simple reasons
new drawing → clear the previous result
Clear / Retry → reset the attempt

Stacked on implement/strokes; preserves the existing writing-feature layout.

Evidence

  • Before: drawing only recorded gestures. New tests failed for the absent Check control and exposed a dot-only false pass.
  • After: pnpm check, pnpm test (2 fence, 21 content/session/checker, 15 browser), and pnpm build passed after merging the base branch. Commit and merge hooks remained enabled.
  • Tests cover missing parts, stray ink, correction, retained learner ink, resize, resets, stale results, and direction/order/retracing invariance. Generated near-threshold cases cover sampling and segmentation; an intentional missing-coverage defect was detected and removed.
  • Independent standards review passed. Spec review found one pad-edge tolerance issue; the test-first fix and follow-up spec review passed. Regression tests cover small off-pad marks, accumulated exterior/interior ink, and huge finite excursions.

Merge Danger

Door: two-way

Blast Radius: practice

Margins are provisional and uncalibrated; the original reference remains marked review pending. No persistence, infrastructure, or deployment changes. Physical devices have not been checked.

Closes #7

@joshpitzalis
joshpitzalis marked this pull request as ready for review October 24, 2026 14:09
@joshpitzalis
joshpitzalis added this pull request to stack #9 October 24, 2026 14:38
Preserve the integrated whole-letter assessment, stray tolerance fix, and merge resolutions in a linear commit.
@joshpitzalis
joshpitzalis force-pushed the implement/7-whole-letter branch from 36dd4ce to d563d0e Compare October 24, 2026 17:04
@joshpitzalis
joshpitzalis merged commit 4f90364 into main Oct 24, 2026
1 check passed
@joshpitzalis
joshpitzalis deleted the implement/7-whole-letter branch October 24, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assess the finished letter against a forgiving reference trace

1 participant