Repository navigation
Check finished letters against the reference trace - #8
Merged
Merged
Conversation
joshpitzalis
marked this pull request as ready for review
October 24, 2026 14:09
Preserve the integrated whole-letter assessment, stray tolerance fix, and merge resolutions in a linear commit.
joshpitzalis
force-pushed
the
implement/7-whole-letter
branch
from
October 24, 2026 17:04
36dd4ce to
d563d0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check a complete letter attempt against its reference trace when the learner presses Check, regardless of stroke order, direction, pen lifts, or retracing.
Stacked on
implement/strokes; preserves the existing writing-feature layout.Evidence
pnpm check,pnpm test(2 fence, 21 content/session/checker, 15 browser), andpnpm buildpassed after merging the base branch. Commit and merge hooks remained enabled.Merge Danger
Door: two-way
Blast Radius: practice
Margins are provisional and uncalibrated; the original reference remains marked review pending. No persistence, infrastructure, or deployment changes. Physical devices have not been checked.
Closes #7