Repository navigation
Add local Hindi tracing preview and enforced boundaries - #6
Merged
Merged
Conversation
Move the drawing session and practice UI out of the old practice module so the page composes the header, canvas, feedback, and controls. Co-authored-by: Cursor <cursoragent@cursor.com>
Record that a finished letter is checked against an authored example, and that a different letter form needs its own trace. Co-authored-by: Cursor <cursoragent@cursor.com>
The practice slice now uses a singular use-case folder, with domain utils and tracing constants, and the assessment note records the confirmed letter check. Co-authored-by: Cursor <cursoragent@cursor.com>
joshpitzalis
marked this pull request as ready for review
October 24, 2026 13:28
Test touch layouts with mobile browser emulation. Run browser tests against the production preview to avoid dev-module startup timeouts.
Let the browser context dispose of the touch session after the test instead of detaching between drawing and the Retry tap.
Linux delivered raw pointer and touch events to Retry without generating its click. Use Chromium's full touch gesture for button activation and remove temporary event diagnostics.
Use the documented Chromium channel instead of the separate headless shell, keeping the standard Retry tap and original reset assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a local Hindi tracing preview to the Void/React scaffold. A learner can draw separate gestures, reveal ordered reference strokes, clear, and retry. The original development letter is visibly marked review pending.
Closes #2. Tracks #1 and #3; #3 remains open for human lesson review and device evidence. #4 and #5 remain blocked. Specification: SPEC.md.
Evidence
After: browser checks exercise visible live ink, separate gestures, Clear/Retry, Reveal, secondary pointers, cancellation, capture loss, blur, release outside, and resize recovery/alignment.
pnpm check,pnpm test, andpnpm buildpass locally with real pre-commit hooks. The fence probes intentionally invalid types, floating Effects, forbidden imports, and browser globals in domain code. CI repeats frozen installation and check/test/build.Remaining gates
Merge Danger
Door: two-way
No stored learner data or migrations. Reverting removes the local preview and scaffold.
Blast Radius: practice
Introduces the toolchain, local drawing page, hooks, and CI. This draft remains an incomplete implementation of the full checked-exercise specification.