Repository navigation
Fail the deployment check when .env exports a public base URL - #61
Merged
Merged
Conversation
An export prefix hid the key, so the checker kept the loopback default and passed. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
export OLLAMA_BASE_URL=...was stored under the keyexport OLLAMA_BASE_URL, so the deployment check never saw that URL.exportprefix is now stripped, and a public URL failsbase_url.Test plan
export OLLAMA_BASE_URL=http://8.8.8.8:11434fails the base URL check (it passed before this change)tests.test_safetyandtests.test_deployment_safety_ciMade with Cursor