Skip to content

Fail committed addresses written with a leading zero - #56

Merged
jmjava merged 1 commit into
mainfrom
cursor/fail-leading-zero-ipv4
Nov 1, 2026
Merged

Fail committed addresses written with a leading zero#56
jmjava merged 1 commit into
mainfrom
cursor/fail-leading-zero-ipv4

Conversation

@jmjava

@jmjava jmjava commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • The committed-address scan dropped any dotted quad that ipaddress rejects, so 010.010.010.010 and 008.008.008.008 passed.
  • A quad with a leading zero on an octet is now a hit. Ordinary placeholders, loopback, and unspecified addresses still pass.

Test plan

  • 010.010.010.010 and 008.008.008.008 fail committed_ips (they passed before this change)
  • tests.test_safety and tests.test_deployment_safety_ci pass with no live Ollama
  • CI unit and mutation checks green

Made with Cursor

@jmjava @cursoragent
Fail committed addresses written with a leading zero.
52debae 
ipaddress rejects those dotted quads, and the scan treated the parse error as no address.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jmjava
jmjava merged commit de2c0f1 into main Nov 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jmjava