Repository navigation
Fail the address scan when a tracked file cannot be read - #55
Merged
Merged
Conversation
An undecodable text file was skipped, so the scan treated that tree as empty. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git ls-filessucceeded, a tracked text file that was not valid UTF-8 was skipped, and the committed-address check passed as if the tree were empty.Test plan
notes.mdcontaining8.8.8.8plus a non-UTF-8 byte failed the scan only after this changegit ls-filesfailure still fails, andtests.test_safetyplustests.test_deployment_safety_cipassMade with Cursor