Repository navigation
Conversation
Generated with OpenAI Codex
allenflux
marked this pull request as ready for review
October 14, 2026 05:14
jknack
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Writer fails while rendering text at the start of a line, the zero-based template column is passed to
HandlebarsError, which requires a positive column. The resultingIllegalArgumentExceptionhides the original write failure reported in #1070.Normalize the diagnostic column to at least 1, matching
HbsErrorReporter, and use it in both the error object and message header. This preserves the original exception as the cause ofHandlebarsExceptionwithout changingTemplate.position()or positive column values.One regression test uses a Writer that throws an
IOExceptionon the first text write. It fails on the original implementation and passes with this change, checking that the original cause is preserved and the diagnostic column is 1.Validation on Temurin 21 (Java 17 compilation target):
mvn -pl handlebars -am test: 1,039 tests, zero failures/errors, 3 existing skips. The baseline ran 1,038 tests with the same skips.git diff --checkpassed.Fixes #1070.
Implemented with assistance from OpenAI Codex.