Repository navigation
Preserve precision when comparing numbers of the same type - #1192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the existing comparison method for same-class, comparable numbers before falling back to
double. This keeps distinctLong,BigInteger, andBigDecimalvalues distinct ineq/neq.Keeps the existing mixed-type fallback and floating-point equality behavior, including signed zero. Tests cover template output, big numbers, decimal scale, and those compatibility cases.
Validation:
mvn -pl handlebars -am verify— 1,041 tests, no failures, 3 skipped (JDK 21). Changed Java files formatted with Spotless.Fixes #1191.