Repository navigation
Log requests at log level INFO - #715
Merged
Merged
Conversation
gitit sets up the Happstack.Server.AccessLog.Combined logger with the log file and level, but since the migration to happstack 6 it passed logAccess = Nothing in the server configuration, so requests were never logged. Use happstack's default access logger (combined log format) when the log level is INFO or DEBUG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitit configures the
Happstack.Server.AccessLog.Combinedlogger with the log file and level (gitit.hs), but the server configuration passeslogAccess = Nothing, so no requests are ever logged, whateverlog-levelsays. This dates from the migration to happstack 6 (c0f4586), whenConfgained thelogAccessfield.This uses happstack's default access logger (
logAccess nullConf) when the log level is INFO or DEBUG, and keeps it off otherwise, so the defaultlog-level: WARNINGbehaves as before. Withlog-level: INFO, each request is logged in combined log format, e.g.Tested on gitit 0.16.0.2 with GHC 9.6.7.
🤖 Generated with Claude Code