Repository navigation
Escape literal parent directories in glob searches - #274
Open
Apeksha9389 wants to merge 1 commit into
Open
Apeksha9389 wants to merge 1 commit into
Apeksha9389 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path.glob()andPath.iglob()treat wildcard characters in the parent directory as part of the search pattern. A directory named[reports]can consequently return files from a sibling namedrinstead of its own files.Escape the parent directory before joining the caller's pattern, leaving wildcard matching in that pattern intact. Parameterized regressions cover both APIs, including a matching sibling directory that must not be searched. Add a Towncrier fragment.
Validation on macOS/Python 3.12: both regression cases fail on unmodified main.
tox -e py312passes (166 passed, 1 skipped), including mypy and documentation checks. Explicit Ruff lint and formatting checks pass. Windows and the other Python versions were not run locally.AI disclosure: The patch, tests, and description were prepared with OpenAI Codex assistance; the reported checks were executed locally.