Repository navigation
Key matcher pattern cache by normalizer identity - #269
Open
blouirts123 wants to merge 1 commit into
Open
blouirts123 wants to merge 1 commit into
blouirts123 wants to merge 1 commit into
Conversation
blouirts123
marked this pull request as draft
October 16, 2026 04:52
blouirts123
marked this pull request as ready for review
October 16, 2026 05:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing one
matchers.Pattern('*.TXT')acrossntpathandposixpathPath variants can missFile.TXTon the second traversal in either order. The normalized glob is cached without recording which normalizer produced it.Key a single cache entry by normalizer identity and publish the key/value together. Preserve repeated bound-method cache hits, avoid user-defined callable equality, and discard transient cache state during pickling so subclass dictionary/slot state still round-trips. Add module-order, callable-metadata and pickle regressions plus a Towncrier fragment.
Validation: root and independent focused class: 14 passed; filtered functional suite: 129 passed, 7 skipped, 12 symlink-dependent tests deselected. Docs and formatting pass; final changed-line coverage is 100% (82 lines). Full tox remains blocked locally by existing Ruff/mypy findings and Windows symlink privileges. Controlled baseline comparison reproduced those failures, and final diagnostics add no Ruff finding or changed-file type error. A concurrent mixed-normalizer probe and fragment draft rendering also pass. No performance claim is made.