Repository navigation
feat: add config schema for settings - #7
Open
turegjorup wants to merge 1 commit into
Open
turegjorup wants to merge 1 commit into
turegjorup wants to merge 1 commit into
Conversation
Without a schema, config validation (e.g. drush config:inspect) reports web_accessibility_statement.settings as having no schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a config schema for
web_accessibility_statement.settings, so sites using the module pass config schema validation.Changes
config/schema/web_accessibility_statement.schema.ymldescribing the one setting the module uses,url(uri, nullable to match the install defaulturl: ~).Why
Drupal sites are getting a CI check that validates config against its schema (
drush config:inspect --only-error, itk-dev/devops_itkdev-docker#160). Without a schema the check reportsweb_accessibility_statement.settingsas "No schema" and fails, as it does on itk-dev/doner-din-stemme#72.Not changed:
config/install/web_accessibility_statement.accessibilityadmin.ymlis installed but never read by the module; it gets no schema here.