Skip to content

Fix: Consistent handling of --limit/node CLI parameter - #3979

Merged
ipspace merged 4 commits into
devfrom
nodeset-from-args
Oct 27, 2026
Merged

ipspace merged 4 commits into
devfrom
nodeset-from-args

Conversation

@ipspace

@ipspace ipspace commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Various CLI commands used inconsistent handling of the --limit/node parameter, sometimes not even reporting an error when the resulting nodeset was empty. This commit introduces a consistent handling of the --limit parameter (sometimes derived from 'node' parameter).

Various CLI commands used inconsistent handling of the --limit/node
parameter, sometimes not even reporting an error when the resulting
nodeset was empty. This commit introduces a consistent handling of
the --limit parameter (sometimes derived from 'node' parameter).

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Explicit configuration limits bypass unmanaged and unprovisioned node filtering, allowing excluded targets into deployment.

1 open issue
3 resolved since last review

Review effort: Balanced

Comment thread netsim/cli/config.py Outdated
ipspace and others added 2 commits October 27, 2026 15:12
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ipspace
ipspace merged commit 28a7e30 into dev Oct 27, 2026
8 checks passed
@ipspace
ipspace deleted the nodeset-from-args branch October 27, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants