Skip to content

[packaging] Include monitoring data files in distributions - #1868

Draft
Vamsi-2581 wants to merge 2 commits into
interuss:mainfrom
Vamsi-2581:fix/pypi-package-data-1867
Draft

Vamsi-2581 wants to merge 2 commits into
interuss:mainfrom
Vamsi-2581:fix/pypi-package-data-1867

Conversation

@Vamsi-2581

@Vamsi-2581 Vamsi-2581 commented Oct 30, 2026 •

Copy link
Copy Markdown

Fixes #1867.

Before this change, MANIFEST.in included every file under monitoring/. This could package personal configuration, generated output, cache files, and unrelated build files.

This change adds the targeted resource and documentation patterns proposed in review while preserving the version file and Git helper scripts.

Validation

  • Updated the manifest to the maintainer-proposed list.
  • Local package and wheel inspection have not run.
  • Hosted checks are awaiting maintainer approval.
  • EasyCLA remains unsigned and requires the account holder's personal signature.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

CLA Not Signed

@BenjaminPelletier

Copy link
Copy Markdown
Member

I think an outsider contribution minutes after filing an Issue is probably a record -- thanks! Let us know if you have any trouble with the Linux Foundation CLA. It's supposed to be easy to sign, but sometimes isn't.

Comment thread MANIFEST.in Outdated
@@ -1,2 +1,3 @@
include monitoring/_version.py
recursive-include scripts/git *.py
recursive-include monitoring *

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling this is too wide, and that we wanted "targeted" includes.

The official publish via CI is done from a fresh clone, so it's mostly fine, but locally this would include:

  • Personal configurations
  • output/ folders
  • .pyc cache files

(And on a fresh build, this would ship unnecessary files like Dockerfiles, Makefiles, scripts, etc.)

This could also be fixed with excludes (e.g. global-exclude *.py[cod] .gitignore, prune monitoring/uss_qualifier/output).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list I was going to propose would have been:

include monitoring/monitorlib/assets/WW15MGH.DAC
recursive-include monitoring/monitorlib/html/templates *.html *.js
recursive-include monitoring/mock_uss/templates *.html
recursive-include monitoring/prober/scd/resources *.json *.yaml
recursive-include monitoring/uss_qualifier/reports/templates *.html *.template
recursive-include monitoring/uss_qualifier/requirements *.md
recursive-include monitoring/uss_qualifier/scenarios *.md
recursive-include monitoring/uss_qualifier/suites *.yaml

@BenjaminPelletier

Copy link
Copy Markdown
Member

I just wanted to check up on this PR; I think it is valuable and so I'd like to make sure the appropriate adjustments are made. Do you think you'll be able to sign the CLA and make the adjustments suggested above? Otherwise, I can propose an alternate PR.

@Vamsi-2581

Copy link
Copy Markdown
Author

I replaced the broad recursive include with the targeted resource list you proposed in commit 67aa875. I have not built or inspected the package locally, and the hosted workflows are awaiting maintainer approval. The EasyCLA signature is still pending and must be completed by the account holder personally.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

PyPI wheel for interuss-monitoring contains no non-Python files

3 participants