Repository navigation
Conversation
Add pull_request paths-ignore filters to the six build workflows. The root CMake project never builds bindings/, so a C API-only PR no longer runs the x86/ARM/macOS core matrix, and docs- or CODEOWNERS-only PRs run nothing heavy. Pushes to main are unfiltered. Filters are ignore-lists, so an unlisted path still triggers the workflow. Replayed against the PRs of the last 30 days this skips ~12k of ~71k PR-event runner-minutes. Also drop -DSVS_EXPERIMENTAL_LEANVEC=YES from the ARM and macOS builds; the option no longer exists in the CMake project.
napetrov
requested review from
ethanglaser,
homksei,
mihaic and
yuejiaointel
as code owners
October 16, 2026 19:33
Member
|
Thanks for checking on this, closing in favor of #436 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #432
Summary
pull_request.paths-ignorelist.pushtomainandworkflow_dispatchare unchanged and still run everything.include/**,cmake/**) still triggers every workflow.bindings/; onlybindings/{c,cpp}pull in the core viaadd_subdirectory(../..).-DSVS_EXPERIMENTAL_LEANVEC=YESfrom ARM and macOS. That option no longer exists; it is only mentioned inHISTORY.md.Evidence
build-linuxalone.Checks:
include/or core plus bindings still run every workflow.pre-commit(check yaml) passes, andactionlintreports no issues.main, so a skipped workflow cannot leave a PR stuck waiting on a pending check.Merge Danger
Door: two-way
Blast Radius: CI-only
maininstead of on the PR. The lists were derived from the CMake structure:bindings/is not built by the root project;tests/,utils/andbenchmark/are off unlessSVS_BUILD_*are set, which the binding scripts don't do.🤖 Generated with Claude Code