Repository navigation
Conversation
The four Concurrent MutableVamanaIndex stress tests added in #369 build a 20k-point index with 8 threads. On 4-vCPU CI runners they take ~550 s of serial ctest time, more than half the suite, in every matrix job. Use the existing small (TSan) problem size by default and keep the full size behind the new SVS_TEST_CONCURRENT_FULL_SIZE CMake option for stress runs. Races and broken invariants show up just as readily at small size.
napetrov
requested review from
ahuber21,
mihaic,
rfsaliev and
yuejiaointel
as code owners
October 16, 2026 19:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #432
Summary
New CMake option
SVS_TEST_CONCURRENT_FULL_SIZE(defaultOFF, intests/CMakeLists.txt) restores the full size for stress runs, e.g. a future nightly (#432).Since #369, the four
Concurrent MutableVamanaIndexstress tests make up more than half of serial ctest time, and they run in every x86/ARM/macOS matrix job, including ASAN Debug. Per-push CI cost went from 346 to 521 runner-minutes after #369 landed.Evidence
Measured locally with
taskset -c 0-3(4 cores, the same as a GitHub-hosted runner), RelWithDebInfo,ctest -R "Concurrent MutableVamanaIndex":--repeat until-fail:5, 30 of 30 runs pass, so the coarse recall thresholds hold at small size.-DSVS_TEST_CONCURRENT_FULL_SIZE=ONadds the define to theteststarget only, which I checked inflags.make.Merge Danger
Door: two-way
Blast Radius: tests-only
🤖 Generated with Claude Code