Skip to content

docs: stop vendoring igraph.r2cdocs, put it within R/ - #3007

Open
maelle wants to merge 2 commits into
mainfrom
roclet-not-vendored
Open

maelle wants to merge 2 commits into
mainfrom
roclet-not-vendored

Conversation

@maelle

@maelle maelle commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread R/roxygen-cdocs.R
"roclet_output",
"roclet_docs_rd",
roclet_output.roclet_docs_rd,
envir = asNamespace("roxygen2")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we could do something simpler

Comment thread R/roxygen-cdocs.R

# The link tables in the cache, named by the release.
c_links_tables <- function() {
files <- dir(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused because I thought we had already switched to the user directory caching that this PR has.

@maelle
maelle requested a review from krlmlr October 23, 2026 09:56
@maelle
maelle marked this pull request as ready for review October 23, 2026 09:56
@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 059125d is merged into main:

  • ✔️E_named: 196ms -> 199ms [-1.61%, +4.75%]
  • ✔️V_named: 470ms -> 482ms [-3.79%, +8.56%]
  • ✔️all_simple_paths_named: 97.1ms -> 97.1ms [-2.11%, +2.07%]
  • ✔️as_adjacency_matrix: 205ms -> 205ms [-2.22%, +1.82%]
  • ✔️as_biadjacency_matrix: 241ms -> 244ms [-1.26%, +3.8%]
  • ✔️as_data_frame_both: 187ms -> 185ms [-3.12%, +0.94%]
  • ✔️as_long_data_frame: 152ms -> 153ms [-1.87%, +3.1%]
  • ✔️degree_few_vertices: 72.2ms -> 71.5ms [-3.37%, +1.41%]
  • ✔️ego_order2_named: 128ms -> 128ms [-1.41%, +2.48%]
  • ✔️es_attr_assign: 204ms -> 202ms [-3.34%, +1.36%]
  • ✔️es_attr_filter: 204ms -> 201ms [-3.52%, +0.81%]
  • ✔️graph_from_adjacency_matrix: 247ms -> 242ms [-4.25%, +0.76%]
  • ✔️graph_from_data_frame: 222ms -> 221ms [-2.62%, +1.55%]
  • ✔️head_of_named: 133ms -> 134ms [-2%, +3.41%]
  • ✔️incident_edges: 159ms -> 158ms [-2.17%, +0.99%]
  • ✔️max_cliques_named: 20.2ms -> 20.2ms [-1.38%, +1.75%]
  • ✔️neighbors_by_name: 148ms -> 149ms [-1.16%, +3.45%]
  • ✔️union_named: 197ms -> 197ms [-1.99%, +2.13%]
  • ✔️vs_attr_filter: 221ms -> 222ms [-1.35%, +3.05%]
  • ✔️vs_by_name: 185ms -> 182ms [-4.16%, +0.63%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if d407158 is merged into main:

  • ✔️E_named: 122ms -> 122ms [-0.63%, +1.45%]
  • ✔️V_named: 257ms -> 249ms [-7.15%, +1.02%]
  • ✔️all_simple_paths_named: 92.6ms -> 92ms [-1.61%, +0.36%]
  • ✔️as_adjacency_matrix: 120ms -> 123ms [-1.99%, +7.89%]
  • ✔️as_biadjacency_matrix: 136ms -> 139ms [-0.23%, +4.1%]
  • ✔️as_data_frame_both: 136ms -> 136ms [-1.91%, +1.67%]
  • ✔️as_long_data_frame: 118ms -> 117ms [-4.33%, +2.66%]
  • ✔️degree_few_vertices: 56ms -> 56.6ms [-0.21%, +2.42%]
  • ✔️ego_order2_named: 100ms -> 100ms [-0.98%, +1.8%]
  • ✔️es_attr_assign: 131ms -> 131ms [-1.43%, +0.98%]
  • ✔️es_attr_filter: 135ms -> 135ms [-0.17%, +1.21%]
  • ✔️graph_from_adjacency_matrix: 154ms -> 154ms [-0.72%, +0.72%]
  • ✔️graph_from_data_frame: 155ms -> 156ms [-1.19%, +1.49%]
  • ✔️head_of_named: 103ms -> 105ms [-0.7%, +2.95%]
  • ✔️incident_edges: 114ms -> 113ms [-2.36%, +0.16%]
  • ✔️max_cliques_named: 17.6ms -> 17.7ms [-1.2%, +1.36%]
  • ✔️neighbors_by_name: 111ms -> 111ms [-3.07%, +3.57%]
  • ✔️union_named: 138ms -> 138ms [-0.94%, +1.28%]
  • ✔️vs_attr_filter: 165ms -> 165ms [-0.76%, +1.32%]
  • 🚀vs_by_name: 143ms -> 141ms [-3.41%, -0.17%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant