Repository navigation
Use the next bucket's first observation if available - #582
Open
daniel-slaugh wants to merge 1 commit into
Open
daniel-slaugh wants to merge 1 commit into
daniel-slaugh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #581
The policy I adopted is to use the next bucket's first value for interpolation if available. For example, with time-weighted mean, if we're aggregating to daily on the day the data were collected, then we may get an average of 5 (tomorrow's data don't exist yet). The next day's data come in and we recompute. Because we interpolate using the next bucket's first data point, the new average is 5.33.
It's a bit of an edge case, but will be a more accurate daily mean overall.