Repository navigation
modem-pay: add 1 doc-sourced sample (charge.succeeded) - #79
Merged
Merged
Conversation
Copied as-is from hookdeck/webhook-registry samples-doc/providers/modem-pay (registry #128). The body's top-level `event` resolves to charge.succeeded, which matches the file name and the `topic` field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D7eqaQdKAUzQXRbGtym1PF
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Mirrors the registry follow-up that makes the harvester export the sample with the customer email as customer@example.com and the IP as 192.0.2.183 (TEST-NET-1), in both payment_metadata.ipAddress and urlIPAddress. Nothing else changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D7eqaQdKAUzQXRbGtym1PF
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Gareth · project thread
Merge after the registry follow-up to hookdeck/webhook-registry#128. That follow-up makes the harvester replace the PII in the Modem Pay sample, and this PR mirrors its output. #128 itself is merged: it added the
modem-payandscaleway-topics-and-eventsrows and thesamples-docfile this PR copies.Before: Hookdeck has
MODEM_PAYandSCALEWAY_TOPICS_AND_EVENTSsource types, but this repo had no samples for either.After:
providers/modem-pay/holds 1 doc-sourced sample,latest/charge.succeeded.json. It is the "Sample Webhook Event" from Modem Pay's webhooks page, and it is the only delivery body their docs publish.index.jsonhastopic_identifier: "event"and provenancedocs. The body's top-leveleventresolves tocharge.succeeded, which matches the file name and thetopicfield.Three fields in the vendor's example are worth knowing about:
payload.customer_emailwas a real-looking Gmail address in Modem Pay's docs. It is nowcustomer@example.com.payload.payment_metadata.ipAddressandurlIPAddressheld a real public IP. Both now use192.0.2.183, from the TEST-NET-1 documentation range.payload.payment_accountis".... 9944"and stays as it is. This is a masked account number in the form Modem Pay's dashboard shows. The value is not cut short.Nothing else differs from the vendor's example. The file should be byte-identical to the regenerated registry
samples-doccopy once the follow-up lands.Scaleway Topics and Events has no samples. It is a relay, so the publisher writes the message, and the only body its docs show is the subscription confirmation, which uses placeholders.
How: The first commit copies
samples-doc/providers/modem-pay/from registrymainas-is (byte-identical, LF). The second commit applies only the three substitutions above. I checked the topic withresolveTopic, headers first and then body, asrequestReceiver.tsdoes. It givescharge.succeeded, andsafeStemgives the same file stem. After both commits,yarn compilesucceeded andproviders.jsonlists modem-paylatestasdocs.yarn testgave 26 passed, 0 failed.https://claude.ai/code/session_01D7eqaQdKAUzQXRbGtym1PF
Generated by Claude Code