Skip to content

modem-pay: add 1 doc-sourced sample (charge.succeeded) - #79

Merged
garethx merged 2 commits into
mainfrom
feature/samples-modem-pay
Oct 29, 2026
Merged

garethx merged 2 commits into
mainfrom
feature/samples-modem-pay

Conversation

@garethx

@garethx garethx commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Gareth · project thread

Merge after the registry follow-up to hookdeck/webhook-registry#128. That follow-up makes the harvester replace the PII in the Modem Pay sample, and this PR mirrors its output. #128 itself is merged: it added the modem-pay and scaleway-topics-and-events rows and the samples-doc file this PR copies.

Before: Hookdeck has MODEM_PAY and SCALEWAY_TOPICS_AND_EVENTS source types, but this repo had no samples for either.

After: providers/modem-pay/ holds 1 doc-sourced sample, latest/charge.succeeded.json. It is the "Sample Webhook Event" from Modem Pay's webhooks page, and it is the only delivery body their docs publish. index.json has topic_identifier: "event" and provenance docs. The body's top-level event resolves to charge.succeeded, which matches the file name and the topic field.

Three fields in the vendor's example are worth knowing about:

  • payload.customer_email was a real-looking Gmail address in Modem Pay's docs. It is now customer@example.com.
  • payload.payment_metadata.ipAddress and urlIPAddress held a real public IP. Both now use 192.0.2.183, from the TEST-NET-1 documentation range.
  • payload.payment_account is ".... 9944" and stays as it is. This is a masked account number in the form Modem Pay's dashboard shows. The value is not cut short.

Nothing else differs from the vendor's example. The file should be byte-identical to the regenerated registry samples-doc copy once the follow-up lands.

Scaleway Topics and Events has no samples. It is a relay, so the publisher writes the message, and the only body its docs show is the subscription confirmation, which uses placeholders.

How: The first commit copies samples-doc/providers/modem-pay/ from registry main as-is (byte-identical, LF). The second commit applies only the three substitutions above. I checked the topic with resolveTopic, headers first and then body, as requestReceiver.ts does. It gives charge.succeeded, and safeStem gives the same file stem. After both commits, yarn compile succeeded and providers.json lists modem-pay latest as docs. yarn test gave 26 passed, 0 failed.

https://claude.ai/code/session_01D7eqaQdKAUzQXRbGtym1PF


Generated by Claude Code

Copied as-is from hookdeck/webhook-registry samples-doc/providers/modem-pay
(registry #128). The body's top-level `event` resolves to charge.succeeded,
which matches the file name and the `topic` field.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D7eqaQdKAUzQXRbGtym1PF
@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
webhook-samples Ready Ready Preview Oct 29, 2026 5:43pm UTC

Request Review

Mirrors the registry follow-up that makes the harvester export the sample
with the customer email as customer@example.com and the IP as
192.0.2.183 (TEST-NET-1), in both payment_metadata.ipAddress and
urlIPAddress. Nothing else changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D7eqaQdKAUzQXRbGtym1PF
@garethx
garethx merged commit 262be18 into main Oct 29, 2026
3 checks passed
@garethx
garethx deleted the feature/samples-modem-pay branch October 29, 2026 18:00

This branch was successfully deployed

1 active deployment
Preview — 3add6c79 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants