Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexluong
force-pushed
the
perf/attempt-list-payload-columns
branch
from
October 30, 2026 14:34
ffb15a7 to
ecce3bf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt list endpoints always read event data, event metadata and response data from the log store, then drop them unless
includeasks for them. These can be the largest columns in an attempt row, so a list withoutincludeloads payloads that never reach the response. Attempt list reads now take the payload fields to read: the handler asks only for whatincludeneeds, and the stores skip the rest. Responses are unchanged for everyincludecombination.Changes
ListAttemptRequest.Includelists the payload fields to read (event.data,event.metadata,response_data). Nil reads none of them; callers that need the full record passAllFields.Includefrominclude:event.datareads event data,eventorevent.datareads event metadata,response_datareads response data.ListLatestAttemptsfallback passAllFields, so retries still deliver the full event; tests on both retry lookups fail if they stop asking.🤖 Generated with Claude Code