Repository navigation
chore(benchexec): one tool version in the tool-info module - #90
Open
GuilhermeBn198 wants to merge 1 commit into
Open
GuilhermeBn198 wants to merge 1 commit into
GuilhermeBn198 wants to merge 1 commit into
Conversation
Mirrors sosy-lab/benchexec#1352 after review: executable() reads the major version from the wrapper into self._version (the current version if the wrapper does not report one); _major_version is gone. The checklist's H1.4 still named the removed Test-Comp module and wrapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the review change in sosy-lab/benchexec#1352: the tool-info module keeps the tool version in one place.
executable()reads the major version from the wrapper intoself._version(the current version if the wrapper does not report one), and_major_versionis gone.Also updates H1.4 in
docs/TESTCOMP-CHECKLIST.md, which still named the removed Test-Comp module and wrapper.The archive does not ship the tool-info module, so the published archive (DOI 10.5281/zenodo.23672409) is unaffected.
tests/integration/test_benchexec_toolinfo.py: 24 passed.