Repository navigation
chore(migrations): seed codes_enabled setting - #365
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
I'll fix CI failures and address comments. I'll skip comments containing "(aside)".
|
This PR changes database migrations
Merging deploys this code to staging, and the next release deploys it to prod. Neither deploy runs migrations.
CI's |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #363. Seeds the
codes_enabledsetting row like the other boolean settings (000029_seed_points_enabled,000053_seed_decisions_released), so the closed default is stored in the DB rather than only implied byGetCodesEnabled's fallback.ON CONFLICT DO NOTHINGmeans that if a super admin already opened codes after #363 deployed, the migration leaves that row untouched. No code changes.Testing
./scripts/check-migrations.sh: 125 contiguous pairs.truerow survived the first up, down removed it, and the second up seededfalse.Link to Devin session: https://app.devin.ai/sessions/d8e19df93b774e33b38363ae66efd630
Open in Devin Desktop: https://app.devin.ai/desktop/session/d8e19df93b774e33b38363ae66efd630?variant=devin
Requested by: @balebbae