Repository navigation
fix(cypress): scope Cypress configs to CommonJS under ESM root - #2239
Open
JohnyKid123 wants to merge 1 commit into
Open
JohnyKid123 wants to merge 1 commit into
JohnyKid123 wants to merge 1 commit into
Conversation
Author
|
Hi! I've submitted a fix for #2224. The PR is ready for review, but the required checks are still pending, and the workflows appear to need approval. Could a maintainer please take a look when available? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2224
What changes did you make and why?
Added
cypress/package.jsonwith"type": "commonjs"to fix the module compatibility issue caused by the root package's"type": "module"setting.This allows Cypress to load the existing CommonJS plugin export without renaming any files or changing plugin paths.
How to test
Run:
node -e "console.log(typeof require('./cypress/plugins/index.js'))"Expected output:
functionVerified using a minimal reproduction with Node.js 22.16.0. The full Cypress suite was not run.
Screenshots
Not applicable — configuration-only change.
AI assistance
This fix was prepared with AI assistance. The module-loading behavior was checked locally.