Repository navigation
Fail combined deployment when Vercel handoff fails - #2682
Merged
groupthinking merged 2 commits intoNov 16, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🔍 PR Validation |
4 tasks
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
except Exception patterns and add structured error handling
groupthinking
marked this pull request as ready for review
November 16, 2026 18:11
groupthinking
deleted the
copilot/audit-006-reduce-bare-exception-handlers
branch
November 16, 2026 18:11
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An unset VERCEL_TOKEN causes the handoff to fail after a successful GitHub push without a per-handoff failure log, leaving this case out of stage/reason monitoring.
1 open issue
What changed in this PR
Updates the internal deployment MCP tool so a successful GitHub push cannot mask a failed or unavailable Vercel deployment. This addresses one boundary of the broader exception-handling audit.
Changes:
- Require both GitHub and Vercel stages to succeed for overall success.
- Add structured logging for failed Vercel attempts and regression coverage for combined handoff outcomes.
- Document the deployment success contract and correct the exception-lint rule guidance.
| File | Description |
|---|---|
tests/unit/test_deployment_handoff_failures.py |
Adds mocked cases for Vercel failure, missing configuration, and successful handoffs. |
src/agents/mcp_tools/deployment_tool.py |
Requires both deployment stages and logs failed Vercel attempts. |
docs/EXCEPTION_HANDLING_STANDARDS.md |
Clarifies handoff requirements, lint rules, and focused verification. |
Review effort: Max
| @@ -149,7 +153,7 @@ async def deploy_to_github_and_vercel( | |||
| }) | |||
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Canonical issue
AUDIT-006 — exception handling and fail-closed critical paths.
Outcome
A successful GitHub push no longer masks a failed or unavailable Vercel deployment. This addresses one deployment boundary; the wider critical-path audit remains open.
Scope
Risk
Verification
Head:
276653f3365cfe6a8cb8ce828b61037aec32c83dThe full Python suite stopped during collection because
aiohttpwas unavailable. CodeQL reported no Python alerts.Production evidence
Not applicable; no deployment was performed.
Agent handoff
Security dependency evidence
except Exceptionpatterns; add structured error handling #2168