Skip to content

Fail combined deployment when Vercel handoff fails - #2682

Merged
groupthinking merged 2 commits into
mainfrom
copilot/audit-006-reduce-bare-exception-handlers
Nov 16, 2026
Merged

groupthinking merged 2 commits into
mainfrom
copilot/audit-006-reduce-bare-exception-handlers

Conversation

@groupthinking

@groupthinking groupthinking commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Canonical issue

AUDIT-006 — exception handling and fail-closed critical paths.

Outcome

A successful GitHub push no longer masks a failed or unavailable Vercel deployment. This addresses one deployment boundary; the wider critical-path audit remains open.

Scope

  • Included:
    • Require both GitHub and Vercel deployment stages for overall success.
    • Log Vercel failures with structured stage and reason fields.
    • Add regression coverage and update exception-handling guidance.
  • Explicitly excluded:
    • Repository-wide handler inventory and remaining auth and agent remediation.

Risk

  • Risk level: medium
  • Failure mode: GitHub-only handoffs now report failure instead of success.
  • Rollback: Revert this commit.

Verification

Head: 276653f3365cfe6a8cb8ce828b61037aec32c83d

  • Focused tests: 9 deployment handoff tests passed.
  • Required CI
  • Review threads resolved

The full Python suite stopped during collection because aiohttp was unavailable. CodeQL reported no Python alerts.

Production evidence

Not applicable; no deployment was performed.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

Security dependency evidence

  • Advisory: Not applicable
  • Package and versions: Not applicable
  • Validation: Not applicable
  • Rollback: Not applicable

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Nov 16, 2026 3:56pm UTC

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ PR title should follow conventional commits format

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation python labels Nov 16, 2026
@groupthinking groupthinking changed the title [WIP] Reduce bare except Exception patterns and add structured error handling Fail combined deployment when Vercel handoff fails Nov 16, 2026
@groupthinking
groupthinking marked this pull request as ready for review November 16, 2026 18:11
Copilot AI max review requested due to automatic review settings November 16, 2026 18:11
@groupthinking
groupthinking merged commit 4062eb8 into main Nov 16, 2026
39 of 40 checks passed
@groupthinking
groupthinking deleted the copilot/audit-006-reduce-bare-exception-handlers branch November 16, 2026 18:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

An unset VERCEL_TOKEN causes the handoff to fail after a successful GitHub push without a per-handoff failure log, leaving this case out of stage/reason monitoring.

1 open issue
What changed in this PR

Updates the internal deployment MCP tool so a successful GitHub push cannot mask a failed or unavailable Vercel deployment. This addresses one boundary of the broader exception-handling audit.

Changes:

  • Require both GitHub and Vercel stages to succeed for overall success.
  • Add structured logging for failed Vercel attempts and regression coverage for combined handoff outcomes.
  • Document the deployment success contract and correct the exception-lint rule guidance.
File Description
tests/​unit/​test_deployment_handoff_failures.py Adds mocked cases for Vercel failure, missing configuration, and successful handoffs.
src/​agents/​mcp_tools/​deployment_tool.py Requires both deployment stages and logs failed Vercel attempts.
docs/​EXCEPTION_HANDLING_STANDARDS.md Clarifies handoff requirements, lint rules, and focused verification.

Review effort: Max

@@ -149,7 +153,7 @@ async def deploy_to_github_and_vercel(
})

This branch was successfully deployed

1 active deployment
Preview — 276653f3 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AUDIT-006] Reduce bare except Exception patterns; add structured error handling

3 participants