Skip to content

add: support for multiple credentials in target creation and modification - #1401

Draft
ozgen wants to merge 1 commit into
mainfrom
add/target-multiple-credentials
Draft

ozgen wants to merge 1 commit into
mainfrom
add/target-multiple-credentials

Conversation

@ozgen

@ozgen ozgen commented Nov 3, 2026

Copy link
Copy Markdown
Member

What

  • Added support for multiple credentials in create_target() and modify_target().
  • Kept backward compatibility with existing single-credential parameters.
  • Added unit tests for multiple credential types and combinations.

Why

To allow python-gvm to create and modify targets with multiple credentials of the same type.

References

GEA-2186

Checklist

  • I have added tests for the changes
  • I have used the following LLMs/AI tools in this pull request: Codex/GPT-6 Sol

@ozgen
ozgen requested a review from a team as a code owner November 3, 2026 07:45
@ozgen
ozgen marked this pull request as draft November 3, 2026 07:45
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA d95e284.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.51%. Comparing base (7a54a67) to head (d95e284).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1401   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files         106      106           
  Lines        6993     7004   +11     
  Branches     1288     1291    +3     
=======================================
+ Hits         6889     6900   +11     
  Misses         74       74           
  Partials       30       30           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant