Repository navigation
fix: parse zone-less fallback strings at the fixed offset in dateTimeUtc - #103
Merged
Merged
Conversation
korvin89
marked this pull request as ready for review
October 30, 2026 12:19
ValeraS
requested changes
Oct 30, 2026
Co-authored-by: Valerii Sidorenko <balepas@nebius.com>
ValeraS
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102
The native Date fallback from #91 parsed strings that no regex in parseDateString matches (e.g. "2024/01/01") in the system time zone, so dateTimeUtc() returned a value shifted by the local UTC offset (
2023-12-31 21:00instead of2024-01-01 00:00under Europe/Moscow).With a fixed offset the fallback now uses
dayjs.utc(input), as in 2.5.x, and shifts the result by the offset, same as theformatbranch. dayjs.utc reads zone-lessYYYY/MM/DD-like strings as UTC and hands everything else (e.g.Date.toString()output from #91) to the native parser, so those still keep their instant.dateTime()without a fixed offset is unchanged.