Repository navigation
Conversation
- the [_emitSymbol] member is @internal like the symbol itself: stripInternal removed the symbol and left the member that names it - GridLayout.render() returns React.ReactNode: the inferred type spelled out ReactNode of @types/react 19 and did not fit a consumer on @types/react 18 - @types/react-grid-layout moves to dependencies: the public types import react-grid-layout, which ships no types
test:build now compiles the .d.ts of both builds with skipLibCheck: false and requires the @types package of a dependency without its own types in dependencies.
- a default item (copy, delete, settings) given as an object without title shows its default text instead of the raw id - default items given as strings next to custom items are no longer dropped - iconSize of a menu item is deprecated: the menu never applied it
A consumer app moved from DashKit 10 + uikit 7 to DashKit 11 + uikit 8 by the guide. - Jest: the error texts of Jest 29 and 30, the ts-jest and babel-jest setups that work, a snippet - Language: the texts re-render on a language change, the DashKit 10 workaround can go - menu: role="menu" is on the popup element; the fixed default items; iconSize deprecated - types: @types/react-grid-layout is a dependency, skipLibCheck: false works - Node: the main entry imports CSS; a local path to the uikit guide
A settings id given as a string is left to the gear button, next to custom items as well as in a menu of ids only; an object without title still shows it. README states the rule; tests pin it and the id fallback of a custom item. The comment on _emitSymbol says what it hides.
- find @types packages through TypeScript's own module resolution instead of a manifest heuristic - compile the declarations under bundler, nodenext (ESM and CommonJS) and node10 (typesVersions) - fail on types spelled out from @types/react 19, which break consumers on @types/react 18 - compare diagnostic paths in a way that also works on Windows
- Jest: ts-jest 29.3.2+ transforms node_modules files by itself (measured 29.2.5, 29.3.x, 29.4.15), babel-jest needs a project-wide babel.config.js, a transformer for two packages works with any ts-jest; a pnpm pattern; keep the CSS stub and jsdom - types: @types/react 18.2.6+, esModuleInterop with node10, deduping @types/react - menu: the settings id rule; language: the application's own texts stay its own
Contributor
|
Preview is ready. |
They need no action from an application; README describes the default items. Addresses: 4564396064
Addresses: 4564427343
korvin89
marked this pull request as ready for review
November 13, 2026 14:33
korvin89
requested review from
Marginy605,
daniil-filippov-dev,
mournfulCoroner and
roberthovsepyan
as code owners
November 13, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes on
release/v11found by a consumer check: a small app on DashKit 10 + uikit 7 was moved to DashKit 11 + uikit 8 by the migration guides. It installed, built and passed its tests on React 18 and 19 without test changes; these are the problems it hit in DashKit.skipLibCheck: false, andtest:buildnow checks that.Details
Types
DashKit 10 and the first DashKit 11 build needed
skipLibCheck: truein a consumer (7 errors in the.d.ts):[_emitSymbol]member ofDashKitis@internallike the symbol itself:stripInternalremoved the symbol and left the member that names it;GridLayout.render()returnsReact.ReactNode: the inferred type spelled outReactNodeof@types/react19 and failed for a consumer on@types/react18 (TS2416, reproduced by installing it);@types/react-grid-layoutmoves todependencies: the public types importreact-grid-layout, which ships no types.npm run test:buildnow:.d.tswithskipLibCheck: falseunderbundler,nodenext(ESM and CommonJS builds) andnode10(throughtypesVersions, withesModuleInterop), failing only on errors insidebuild/;@typespackage of a dependency whose types TypeScript finds in@types;@types/react19 (bigint,AwaitedReactNode).Each of the three defects, put back one at a time, makes
test:buildfail.Overlay menu
copy,delete,settings) given as an object withouttitleshowed its raw id (copy) in any language; it shows its default text now.copyanddeletegiven as strings were dropped as soon as the menu had one custom item; they are kept now.settingsas a string stays hidden everywhere, as in a menu of strings only, because the gear button opens the settings; as an object it is shown.iconSizeof a menu item is@deprecated: the menu never applied it, and the uikit 8Menusizes item icons itself.iconSizeof anoverlayControlsbutton still works.Migration guide
ts-jest29.3.2+ transforms the two ESM-only packages by itself (measured: 29.2.5 fails, 29.3.0–29.3.1 needisolatedModules, 29.3.2 and 29.4.15 work);babel-jestneeds a project-widebabel.config.js;ts-jest;@types/react18.2.6 or later (React.JSX),esModuleInteropwithnode10, deduping@types/react.role="menu"is on the popup element, not on.g-menu;iconSizeis deprecated. The fixed default items are described in README, not in the guide: they need no action.