Repository navigation
ci: check the build on pull requests - #344
Merged
Merged
Conversation
test:build ran only in prepublishOnly, so a broken build showed up at publish time. A Check Build job builds the package and runs it; the React 18 job runs it after its build.
Contributor
|
Preview is ready. |
The React 18 job does not need a second run of test:build.
korvin89
marked this pull request as ready for review
November 12, 2026 16:11
korvin89
requested review from
Marginy605,
daniil-filippov-dev,
mournfulCoroner and
roberthovsepyan
as code owners
November 12, 2026 16:11
mournfulCoroner
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs
npm run test:buildin CI onrelease/v11.The script (added in #341) loads both builds through the package
exportsand checks that every import is declared. It ran only inprepublishOnly, so a broken build would show up at publish time. It catches what the other checks miss: an undeclared dependency (as lodash and tslib were), different exports of the ESM and CommonJS builds, a broken import path.New job Check Build:
npm ci,npm run build,npm run test:build. It runs on every pull request and on pushes tomain, in parallel with the other jobs.