Skip to content

ci: check the build on pull requests - #344

Merged
korvin89 merged 2 commits into
release/v11from
t-20261109-v11-uikit-v8-ci-test-build
Nov 13, 2026
Merged

korvin89 merged 2 commits into
release/v11from
t-20261109-v11-uikit-v8-ci-test-build

Conversation

@korvin89

@korvin89 korvin89 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Runs npm run test:build in CI on release/v11.

The script (added in #341) loads both builds through the package exports and checks that every import is declared. It ran only in prepublishOnly, so a broken build would show up at publish time. It catches what the other checks miss: an undeclared dependency (as lodash and tslib were), different exports of the ESM and CommonJS builds, a broken import path.

New job Check Build: npm ci, npm run build, npm run test:build. It runs on every pull request and on pushes to main, in parallel with the other jobs.

test:build ran only in prepublishOnly, so a broken build showed up at publish time.
A Check Build job builds the package and runs it; the React 18 job runs it after its build.
@gravity-ui-bot

Copy link
Copy Markdown
Contributor

Preview is ready.

The React 18 job does not need a second run of test:build.
@korvin89
korvin89 merged commit 74ea435 into release/v11 Nov 13, 2026
5 checks passed
@korvin89
korvin89 deleted the t-20261109-v11-uikit-v8-ci-test-build branch November 13, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants